Add Wildcard certificate to ingress resources #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulox
force-pushed
the
wildcard-secret
branch
from
307ec7d
to
e4ae86e
Compare
Rulox
requested review from
Dean-Coakley and
pleshakov
and removed request for
Dean-Coakley
Dean-Coakley
approved these changes
Feb 22, 2019
pleshakov
suggested changes
Feb 22, 2019
Rulox
force-pushed
the
wildcard-secret
branch
from
e4ae86e
to
a69d379
Compare
|
@pleshakov changed! Please re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces Wildcard certificates for ingress resources that have TLS termination enabled but don't specify any secretName.
Checklist
Before creating a PR, run through this checklist and mark each as complete.