Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate-limit example #4907

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Add rate-limit example #4907

merged 7 commits into from
Jan 11, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jan 11, 2024

Proposed changes

  • Add an example to configure rate-limit using an Ingress resource.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner January 11, 2024 12:13
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1cee12) 52.28% compared to head (d4b4614) 52.28%.

❗ Current head d4b4614 differs from pull request most recent head c4da0ce. Consider uploading reports for the commit c4da0ce to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4907   +/-   ##
=======================================
  Coverage   52.28%   52.28%           
=======================================
  Files          60       60           
  Lines       17501    17501           
=======================================
  Hits         9151     9151           
  Misses       8020     8020           
  Partials      330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added two suggestions regarding NGINX as a noun.

vepatel and others added 3 commits January 11, 2024 12:35
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel vepatel enabled auto-merge (squash) January 11, 2024 12:36
@vepatel vepatel merged commit e278e3b into main Jan 11, 2024
19 checks passed
@vepatel vepatel deleted the docs/add-rl-annotation-example branch January 11, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants