Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type ExternalName service support for NGINX Plus #485

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Add type ExternalName service support for NGINX Plus #485

merged 1 commit into from
Feb 5, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Feb 5, 2019 •
edited
Loading

Proposed changes

Closes #262
Closes #446

This PR adds support for type ExternalName services for NGINX Plus only.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Feb 5, 2019
@Rulox Rulox self-assigned this Feb 5, 2019
pleshakov
pleshakov suggested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Please see a few consistency related suggestion and one broken link fix.

examples/externalname-services/README.md Outdated Show resolved Hide resolved
docs/configmap-and-annotations.md Outdated Show resolved Hide resolved
pleshakov
pleshakov approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Dean-Coakley
Dean-Coakley approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Rulox Rulox merged commit 9a21a40 into master Feb 5, 2019
@Rulox Rulox deleted the externalname-support branch February 5, 2019 16:24
@gothub gothub mentioned this pull request Nov 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees

@Rulox Rulox

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External Name Support Support for ExternalName's used for cross-namespace Services
3 participants
@Rulox @pleshakov @Dean-Coakley