Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets to helm chart #430

Merged
merged 5 commits into from
Nov 12, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployments/helm-chart/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: nginx-ingress
version: 0.1.5
version: 0.2.0
appVersion: edge
description: NGINX Ingress Controller
sources:
Expand Down
3 changes: 2 additions & 1 deletion deployments/helm-chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ Parameter | Description | Default
`controller.service.annotations` | The annotations of the Ingress controller service. | { }
`controller.service.loadBalancerIP` | The static IP address for the load balancer. Requires `controller.service.type` set to `LoadBalancer`. | None
`controller.service.externalIPs` | The list of external IPs for the Ingress controller service. | []
`controller.serviceAccountName` | The serviceAccountName of the Ingress controller pods. Used for RBAC. | nginx-ingress
`controller.serviceAccount.name` | The serviceAccountName of the Ingress controller pods. Used for RBAC. | nginx-ingress
Dean-Coakley marked this conversation as resolved.
Show resolved Hide resolved
`controller.serviceAccount.imagePullSecrets` | The names of the secrets containing docker registry credentials. | []
`controller.ingressClass` | A class of the Ingress controller. The Ingress controller only processes Ingress resources that belong to its class - i.e. have the annotation `"kubernetes.io/ingress.class"` equal to the class. Additionally, the Ingress controller processes Ingress resources that do not have that annotation which can be disabled by setting the "-use-ingress-class-only" flag. | nginx
`controller.useIngressClassOnly` | Ignore Ingress resources without the `"kubernetes.io/ingress.class"` annotation. | false
`controller.watchNamespace` | Namespace to watch for Ingress resources. By default the Ingress controller watches all namespaces. | ""
Expand Down
2 changes: 1 addition & 1 deletion deployments/helm-chart/templates/controller-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
prometheus.io/port: "{{ .Values.prometheus.port }}"
{{- end }}
spec:
serviceAccountName: {{ .Values.controller.serviceAccountName }}
serviceAccountName: {{ .Values.controller.serviceAccount.name }}
terminationGracePeriodSeconds: {{ .Values.controller.terminationGracePeriodSeconds }}
{{- if .Values.controller.nodeSelector }}
nodeSelector:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
prometheus.io/port: "{{ .Values.prometheus.port }}"
{{- end }}
spec:
serviceAccountName: {{ .Values.controller.serviceAccountName }}
serviceAccountName: {{ .Values.controller.serviceAccount.name }}
hostNetwork: {{ .Values.controller.hostNetwork }}
containers:
- image: "{{ .Values.controller.image.repository }}:{{ .Values.controller.image.tag }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ .Values.controller.serviceAccountName }}
name: {{ .Values.controller.serviceAccount.name }}
labels:
app: {{ .Values.controller.name | trunc 63 }}
chart: {{ .Chart.Name }}-{{ .Chart.Version }}
heritage: {{ .Release.Service }}
release: {{ .Release.Name }}
{{- if .Values.controller.serviceAccount.imagePullSecrets }}
imagePullSecrets:
{{ toYaml .Values.controller.serviceAccount.imagePullSecrets | indent 4 }}
Dean-Coakley marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion deployments/helm-chart/templates/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ metadata:
release: {{ .Release.Name }}
subjects:
- kind: ServiceAccount
name: {{ .Values.controller.serviceAccountName }}
name: {{ .Values.controller.serviceAccount.name }}
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
Expand Down
5 changes: 4 additions & 1 deletion deployments/helm-chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ controller:
annotations: {}
loadBalancerIP: ""
externalIPs: []
serviceAccountName: nginx-ingress
serviceAccount:
name: nginx-ingress
imagePullSecrets: []
# - name: secret_name
reportIngressStatus:
enable: true
externalService: nginx-ingress
Expand Down