Custom annotations #375
Merged
Custom annotations #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterkellydev
approved these changes
Sep 17, 2018
Now it is possible to get access to the annotations of an Ingress resource from the template for Ingress resources. This allows users to implement custom annotations by modifying the template to insert NGINX configuration based on the presence on an annotation or its value. Additionally, the Ingress name and namespace is also avaiable in the template.
pleshakov
force-pushed
the
custom-annotations
branch
from
9a6cf3f
to
e8b9f51
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements #359
Checklist
Before creating a PR, run through this checklist and mark each as complete.