Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Configurator error check #348

Merged
merged 5 commits into from
Aug 24, 2018
Merged

Fix Configurator error check #348

merged 5 commits into from
Aug 24, 2018

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Fixed error checking in Configurator
    • UpdateEndpoints
    • UpdateEndpointsMergeableIngress
    • AddOrUpdateIngress
    • AddOrUpdateMergeableIngress
  • Added unit tests for all affected functions
  • Fixed typos

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Aug 24, 2018
@Dean-Coakley Dean-Coakley self-assigned this Aug 24, 2018
isaachawley
isaachawley approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@isaachawley isaachawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pleshakov
pleshakov suggested changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small problem

nginx-controller/nginx/configurator_test.go Outdated
t.Errorf("Failed to create a test configurator: %v", err)
}
mergeableIngess := createMergeableCafeIngress()
err = cnf.AddOrUpdateMergableIngress(mergeableIngess)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename Mergable to Mergeable here and everywhere

@Dean-Coakley Dean-Coakley merged commit 01a7db3 into master Aug 24, 2018
@Dean-Coakley Dean-Coakley deleted the fix-cfg-err-check branch August 24, 2018 16:18
isserrano pushed a commit that referenced this pull request Sep 5, 2018
@Dean-Coakley
Fix Configurator error checking (#348)
8a02653 
* Fixed unchecked Configurator errors
* Added unit tests for AddOrUpdateIngress and AddOrUpdateIngressMergeable
* Added unit tests for UpdateEndpoints and UpdateEndpointsMergeableIngress
* Fixed mergeableIngress typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaachawley isaachawley isaachawley approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @isaachawley @pleshakov