Enforce annotations inheritance in minions #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
approved these changes
Aug 3, 2018
pleshakov
added
the
enhancement
isaachawley
approved these changes
Aug 7, 2018
- minions are only allowed to inherent certain annotations from their master Additional changes: - nginx.org/grpc-services is not allowed in the master anymore - nginx.org/server-snippets is not allowed in the minion anymore
pleshakov
force-pushed
the
mergeable-annotations-inheritance
branch
from
ed83c2a
to
3651bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master
Additional changes:
Checklist
Before creating a PR, run through this checklist and mark each as complete.