Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kubernetes ssl-redirect annotation. #199

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

lseelenbinder
Copy link
Contributor

As requested in #198.

I was not certain the acceptable way to test this, so please advise; make test does succeed.

@pleshakov
Copy link
Contributor

@lseelenbinder
Thanks!

There is a small problem: Using $server.sslRedirect in the templates leads to a failure. The correct field is $server.SSLRedirect.

It is possible to test it, if you add the following lines into the Server here:

			SSL:               true,
			SSLCertificate:    "secret.pem",
			SSLCertificateKey: "secret.pem",
			SSLPorts:          []int{443},
			SSLRedirect:       true,

Without changing to $server.SSLRedirect, the test will fail.

Other than that, it works as expected!

Could you fix the problem, change the test and commit the all changes? Please squash all commits into a single one.

@lseelenbinder
Copy link
Contributor Author

Done, @pleshakov. Let me know if there's anything else!

@pleshakov pleshakov merged commit eaa30a3 into nginxinc:master Oct 10, 2017
@pleshakov
Copy link
Contributor

@lseelenbinder thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants