fix: fix broken link DOCOPS-238 #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
vepatel
approved these changes
Sep 10, 2021
| @@ -17,7 +17,7 @@ If you are unsure about which implementation you are using, check the container | |||
|
|
|||
| ## The Key Differences | |||
|
|
|||
| The table below summarizes the key difference between nginxinc/kubernetes-ingress and kubernetes/ingress-nginx Ingress controllers. Note that the table has two columns for the nginxinc/kubernetes-ingress Ingress controller, as it can be used both with NGINX and NGINX Plus. For more information about nginxinc/kubernetes-ingress with NGINX Plus, read [here](nginx-plus.md). | |||
| The table below summarizes the key difference between nginxinc/kubernetes-ingress and kubernetes/ingress-nginx Ingress controllers. Note that the table has two columns for the nginxinc/kubernetes-ingress Ingress controller, as it can be used both with NGINX and NGINX Plus. For more information about nginxinc/kubernetes-ingress with NGINX Plus, read [here](/nginx-ingress-controller/intro/nginx-plus). | |||
There was a problem hiding this comment.
Recommend we rewrite the link so it's not just "here." That's poor style. It's a better UX to say what we're linking to.
ciarams87
added a commit
that referenced
this pull request
Sep 14, 2021
Merge pull request #1949 from nginxinc/DOCOPS-238 fix: fix broken link DOCOPS-238 fix: reword 'here' link to provide more context Merge pull request #1954 from nginxinc/DOCOPS-238b Docops 238b - reword link fix: link examples to git DOCOPS-228 fix: point to the release branch fix: revert change to non-example link fix: revert tree to blob as required fix: tree and blob urls Merge pull request #1959 from nginxinc/DOCS-228 fix: DOCOPS-228 fix links to examples
6 tasks
ciarams87
added a commit
that referenced
this pull request
Sep 15, 2021
Merge pull request #1949 from nginxinc/DOCOPS-238 fix: fix broken link DOCOPS-238 fix: reword 'here' link to provide more context Merge pull request #1954 from nginxinc/DOCOPS-238b Docops 238b - reword link fix: link examples to git DOCOPS-228 fix: point to the release branch fix: revert change to non-example link fix: revert tree to blob as required fix: tree and blob urls Merge pull request #1959 from nginxinc/DOCS-228 fix: DOCOPS-228 fix links to examples Co-authored-by: nginx-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix broken link to the correct URL
(Broken links to examples are being investigated separately in DOCOPS-228)
Closes DOCOPS-238