Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libs compilation for OpenTracing, add more tracers #1907

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Remove libs compilation for OpenTracing, add more tracers #1907

merged 1 commit into from
Aug 27, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 26, 2021 •
edited
Loading

  • Remove steps for building OpenTracing and Jaeger
  • Add support for Zipkin and Datadog
  • Publish the image to DockerHub

@lucacome lucacome requested a review from a team August 26, 2021 23:51
@lucacome lucacome self-assigned this Aug 26, 2021
@lucacome lucacome requested review from ciarams87 and soneillf5 and removed request for a team August 26, 2021 23:51
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Aug 26, 2021
lucacome
lucacome commented Aug 27, 2021
View reviewed changes
build/Dockerfile

ARG JAEGER_VERSION=v0.4.2
############################################# Base image containing libs for Opentracing #############################################
FROM opentracing/nginx-opentracing:nginx-1.21.1 as opentracing-lib
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here because I don't think dependabot can update the image if it's inside a RUN command.

ciarams87
ciarams87 approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucacome lucacome merged commit a0b9af9 into master Aug 27, 2021
@lucacome lucacome deleted the chore/remove-ot-build branch August 27, 2021 15:20
@lucacome lucacome added enhancement Pull requests for new features/feature enhancements and removed chore Pull requests for routine tasks labels Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soneillf5 soneillf5 soneillf5 approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

Assignees

@lucacome lucacome

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @ciarams87 @soneillf5