Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove k8s less v18 test logic #1858

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Feature/remove k8s less v18 test logic #1858

merged 1 commit into from
Aug 18, 2021

Conversation

soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Aug 16, 2021 •
edited
Loading

Proposed changes

This change removes additional mentions of Kubernetes v1.18 from docs and tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Aug 16, 2021
@soneillf5 soneillf5 requested a review from vepatel August 16, 2021 12:28
@pleshakov pleshakov changed the base branch from master to feature/require-k8s-version-min-19 August 16, 2021 23:36
@soneillf5 soneillf5 force-pushed the feature/require-k8s-version-min-19 branch 2 times, most recently from f2124a6 to c7ff8e5 Compare August 17, 2021 09:51
Base automatically changed from feature/require-k8s-version-min-19 to master August 17, 2021 11:17
@soneillf5 soneillf5 force-pushed the feature/remove-k8s-less-v18-test-logic branch from 05e9c87 to cd7dc31 Compare August 17, 2021 12:18
@soneillf5 soneillf5 force-pushed the feature/remove-k8s-less-v18-test-logic branch 2 times, most recently from 273e72a to d64b725 Compare August 18, 2021 09:40
@soneillf5 soneillf5 force-pushed the feature/remove-k8s-less-v18-test-logic branch from d64b725 to 8fd48b1 Compare August 18, 2021 12:38
@soneillf5 soneillf5 merged commit 9708e54 into master Aug 18, 2021
@soneillf5 soneillf5 deleted the feature/remove-k8s-less-v18-test-logic branch August 18, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome lucacome approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soneillf5 @lucacome @pleshakov @vepatel