Add ingressClassName to Policy #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pleshakov
suggested changes
Jul 14, 2021
There was a problem hiding this comment.
Hi @soneillf5
Please see my review. There is a bug and a few suggestions.
soneillf5
force-pushed
the
feature/ingress-class-name-in-policy
branch
from
d81186e to
f1ebca1
Compare
ciarams87
approved these changes
Jul 19, 2021
soneillf5
force-pushed
the
feature/ingress-class-name-in-policy
branch
2 times, most recently
from
2e9afff to
dfad485
Compare
vepatel
approved these changes
Jul 22, 2021
vepatel
reviewed
Jul 22, 2021
vepatel
reviewed
Jul 22, 2021
soneillf5
force-pushed
the
feature/ingress-class-name-in-policy
branch
from
0681e90 to
e93a6cb
Compare
pleshakov
approved these changes
Jul 23, 2021
soneillf5
force-pushed
the
feature/ingress-class-name-in-policy
branch
from
6893a69 to
b53cfc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds a filed
ingressClassNameto a Policy resource. The ingress class is used by the controller to filter out resources that it should not handle. If the ingress class is empty or matches the ingress class of the IngressController then the Policy resource is processed as normal, otherwise it is ignored with no warning or error.Checklist
Before creating a PR, run through this checklist and mark each as complete.