Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IngressClassName in Policy resources #1570

Closed
pleshakov opened this issue May 5, 2021 · 2 comments
Closed

Support IngressClassName in Policy resources #1570

pleshakov opened this issue May 5, 2021 · 2 comments
Labels
enhancement Pull requests for new features/feature enhancements proposal An issue that proposes a feature request

Comments

@pleshakov
Copy link
Contributor

pleshakov commented May 5, 2021 •
edited by brianehlert
Loading

Is your feature request related to a problem? Please describe.

If multiple ICs are running in the cluster and they are not configured to use only a single namespace, they will have access to all Policy resources created in the cluster.

This means it is not possible to assign Policies to different Ingress Controllers, something that Ingress,VirtualServer and TransportServer resources support via ingressClassName field -- see https://docs.nginx.com/nginx-ingress-controller/installation/running-multiple-ingress-controllers/#ingress-class

At minimum, this can create confusion if those IC controllers are configured differently for the -enable-preview-policies argument: if a policy is in preview, an IC with -enable-preview-policies=false will report an error in the Policy status and event, but an IC with -enable-preview-policies=true will report success. (See #1565 )

Describe the solution you'd like Support ingressClassName field in the Policy resource.

Aha! Link: https://nginx.aha.io/features/IC-100
@pleshakov pleshakov added the proposal An issue that proposes a feature request label May 5, 2021
@pleshakov pleshakov mentioned this issue May 5, 2021
Closed
@brianehlert brianehlert added the enhancement Pull requests for new features/feature enhancements label Jul 2, 2021
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Sep 18, 2021
@pleshakov pleshakov removed the stale Pull requests/issues with no activity label Sep 20, 2021
@pleshakov
Copy link
Contributor Author

solved by #1746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements proposal An issue that proposes a feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pleshakov @brianehlert