Allow make to build image when .git directory is missing #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1711 When executing make and building from a downloaded source archive, there is no git history (.git directory) in the source directory. This change allows the build to continue despite that directory being missing. It does that by using dummy values for GIT_COMMIT and GIT_TAG.
|
👷 Deploy request for nginx-kubernetes-ingress accepted. 🔨 Explore the source changes: bbe138d 🔍 Inspect the deploy log: https://app.netlify.com/sites/nginx-kubernetes-ingress/deploys/60dcf0d6b83cb900087f1ed5 |
lucacome
approved these changes
Jun 30, 2021
ciarams87
approved these changes
Jul 1, 2021
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #1711.
When executing make and building from a downloaded source archive, there is no git history (.git directory) in the source directory. This condition causes the make build process to fail.
Proposed changes
This change allows the build to continue despite that directory being missing. It does that by using dummy values for
GIT_COMMITandGIT_TAGwithin theMakefile. ForGIT_COMMITit uses the 7 character valueunknownwhich aligns with the 7 character git hash typically used. ForGIT_TAG, it uses a dummy value ofuntaggedto indicate that there is no tag associated with the build.Checklist
Before creating a PR, run through this checklist and mark each as complete.