Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better exception handling and endpoint readiness check #1708

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 30, 2021

Proposed changes

  • Add custom exception when pods are not ready,
  • Add retry for syslog pods and improve assertion in AP tests,
  • Endpoint readiness in prometheus tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from pleshakov June 30, 2021 14:43
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@vepatel vepatel merged commit 29bb575 into master Jun 30, 2021
@vepatel vepatel deleted the tests/add-pod-exception branch June 30, 2021 15:49
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants