Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests-ts-tls-passthrough #1550

Merged
merged 6 commits into from
Apr 22, 2021
Merged

tests-ts-tls-passthrough #1550

merged 6 commits into from
Apr 22, 2021

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Apr 21, 2021

Proposed changes

  • Add test for tls passthrough
  • Add test for ts host collision
  • general refactoring

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

pleshakov
pleshakov approved these changes Apr 21, 2021
View reviewed changes
tests/suite/test_ts_tls_passthrough.py Outdated Show resolved Hide resolved
tests/suite/test_ts_tls_passthrough.py Show resolved Hide resolved
soneillf5
soneillf5 reviewed Apr 22, 2021
View reviewed changes
tests/suite/test_ts_tls_passthrough.py
transport_server_tls_passthrough_setup.ts_resource,
test_namespace,
)
wait_before_test(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shame about these sleep commands, do we have any waitUntil(condition, timeout) style functions available ?

soneillf5
soneillf5 reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@soneillf5 soneillf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question around using a waitUntil method

@vepatel vepatel merged commit e37a02d into master Apr 22, 2021
@vepatel vepatel deleted the tests/ts-tls-passthrough branch April 22, 2021 14:39
@lucacome lucacome added chore Pull requests for routine tasks python Pull requests that update Python code labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soneillf5 soneillf5 soneillf5 approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vepatel @pleshakov @soneillf5 @lucacome