Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support snippets in TransportServer #1466

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Mar 19, 2021

Proposed changes

Add stream level snippets to transport servers.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 19, 2021
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soneillf5
code looks good!
some comments on the docs

docs-web/configuration/transportserver-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/transportserver-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/transportserver-resource.md Outdated Show resolved Hide resolved
@soneillf5 soneillf5 force-pushed the feature-transportserver-stream-snippets branch from 92fd487 to 08201c8 Compare March 22, 2021 11:49
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Mar 23, 2021
@soneillf5 soneillf5 force-pushed the feature-transportserver-stream-snippets branch from 08201c8 to 883eb5d Compare March 25, 2021 09:35
@soneillf5 soneillf5 force-pushed the feature-transportserver-stream-snippets branch from 883eb5d to 6a25da7 Compare April 27, 2021 14:16
@soneillf5 soneillf5 merged commit 32fdc4e into master Apr 27, 2021
@lucacome lucacome deleted the feature-transportserver-stream-snippets branch April 27, 2021 21:05
@pleshakov pleshakov changed the title Feature transportserver stream snippets Support snippets in TransportServer Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants