Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRDs with controller-tools 0.5.0 #1408

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Update CRDs with controller-tools 0.5.0 #1408

merged 1 commit into from
Feb 24, 2021

Conversation

lucacome
Copy link
Member

Controller tools was updated, so the annotation changed

@lucacome lucacome requested a review from a team February 24, 2021 01:35
@lucacome lucacome self-assigned this Feb 24, 2021
@lucacome lucacome requested review from LorcanMcVeigh and soneillf5 and removed request for a team February 24, 2021 01:35
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 24, 2021
Copy link
Contributor

@soneillf5 soneillf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem straightforward, approved assuming tests pass.

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending tests passing

@lucacome lucacome merged commit 5811592 into master Feb 24, 2021
@lucacome lucacome deleted the chore/update-crds branch February 24, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants