Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap uds tests #1352

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Ap uds tests #1352

merged 2 commits into from
Feb 8, 2021

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Feb 5, 2021

Proposed changes

Add test and lib functions of AP UDS

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@@ -287,6 +351,7 @@ def delete_ap_policy(custom_objects: CustomObjectsApi, name, namespace) -> None:
"appolicies",
name,
)
time.sleep(3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional/required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vepatel vepatel merged commit f0b9b06 into master Feb 8, 2021
@vepatel vepatel deleted the ap-uds-tests branch February 8, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants