Ingress annotation validation earlier in k8s lifecycle #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal validation was performed at the stage when errors can be show to the user in k8s status messages. Most was done later, when errors could only be written to the controller's log file. This change moves some of the validation to the earlier phase, more will follow.
mikestephen
requested review from
pleshakov,
Dean-Coakley,
lucacome,
LorcanMcVeigh and
vepatel
mikestephen
commented
Dec 7, 2020
mikestephen
commented
Dec 7, 2020
mikestephen
commented
Dec 7, 2020
pleshakov
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
@mikestephen looks good! 👏 I think the new annotation validation framework will successfully validate the rest of the annotations
I left a few comments
LorcanMcVeigh
approved these changes
Dec 8, 2020
Dean-Coakley
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Can you satisfy golint before merging?
$ golint internal/configs/parsing_helpers.go
internal/configs/parsing_helpers.go:170:1: exported function ParseInt should have comment or be unexported
internal/configs/parsing_helpers.go:174:1: exported function ParseInt64 should have comment or be unexported
internal/configs/parsing_helpers.go:178:1: exported function ParseUint64 should have comment or be unexported
internal/configs/parsing_helpers.go:207:1: comment on exported const OffsetFmt should be of the form "OffsetFmt ..."
internal/configs/parsing_helpers.go:212:1: exported function ParseOffset should have comment or be unexported
internal/configs/parsing_helpers.go:221:1: comment on exported const SizeFmt should be of the form "SizeFmt ..."
internal/configs/parsing_helpers.go:226:1: exported function ParseSize should have comment or be unexported
internal/configs/parsing_helpers.go:237:1: exported function ParseProxyBuffers should have comment or be unexported
mikestephen
commented
Dec 8, 2020
| } | ||
|
|
||
| // timeRegexp http://nginx.org/en/docs/syntax.html | ||
| var timeRegexp = regexp.MustCompile(`^([0-9]+([ms|s|m|h|d|w|M|y]?){0,1} *)+$`) |
There was a problem hiding this comment.
Building the regexp from the slice of time units didn't seem to be worth the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal validation was performed at the stage when errors can be show to the user in k8s
status messages. Most was done later, when errors could only be written to the controller's
log file. This change moves some of the validation to the earlier phase, more will follow.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.