Support warnings for secrets #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
the
enhancement
Dean-Coakley
approved these changes
Dec 7, 2020
| } | ||
|
|
||
| if err := cnf.nginxManager.Reload(nginx.ReloadForOtherUpdate); err != nil { | ||
| return fmt.Errorf("Error when reloading NGINX when updating %v: %v", resource.GetKind(), err) | ||
| return allWarnings, fmt.Errorf("Error when reloading NGINX when updating %v: %v", resource.GetKind(), err) |
There was a problem hiding this comment.
Would it be good to include resNs/resName here?
Suggested change
| return allWarnings, fmt.Errorf("Error when reloading NGINX when updating %v: %v", resource.GetKind(), err) | |
| return allWarnings, fmt.Errorf("Error when reloading NGINX when updating %v %v/%v: %v", resource.GetKind(), resource.GetNamespace(), resource.GetName(), err) |
There was a problem hiding this comment.
same enhancement can be applied to the other app protect related methods. better to do it in a separate PR
internal/configs/ingress.go
Outdated
| } | ||
|
|
||
| func generateJWTConfig(secretRefs map[string]*secrets.SecretReference, cfgParams *ConfigParams, redirectLocationName string) (*version1.JWTAuth, *version1.JWTRedirectLocation) { | ||
| func generateJWTConfig(owener runtime.Object, secretRefs map[string]*secrets.SecretReference, cfgParams *ConfigParams, |
There was a problem hiding this comment.
Suggested change
| func generateJWTConfig(owener runtime.Object, secretRefs map[string]*secrets.SecretReference, cfgParams *ConfigParams, | |
| func generateJWTConfig(owner runtime.Object, secretRefs map[string]*secrets.SecretReference, cfgParams *ConfigParams, |
pleshakov
force-pushed
the
add-warnings
branch
from
f183008
to
2da1c32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes