Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated imagePullSecrets helm setting #1232

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

In order to be listed in the Rancher App Catalog we need to be able to set imagePullSecrets so that deployments created by Rancher can pull from private docker registries.

However, Rancher only support the following datatypes: string, multiline, boolean, int, enum, password, storageclass, hostname, pvc, secret.

This does not allow to specify a string array as required. This PR changes to accept one string instead of an array. This doesn't affect any known use cases of this field.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the change Pull requests that introduce a change label Nov 17, 2020
@Dean-Coakley Dean-Coakley self-assigned this Nov 17, 2020
@pleshakov
Copy link
Contributor

@Dean-Coakley
will this be added to the release 1.9 branch also?
If that is the case, it's better to have both the old and new parameters, so that we don't introduce any breaking changes in 1.9.* releases.

@Dean-Coakley
Copy link
Contributor Author

@pleshakov Yeah that works for me.

Then I assume we are in agreement that the field controller.serviceAccount.imagePullSecrets will be removed in 1.10 release.

@Dean-Coakley Dean-Coakley merged commit 95623b6 into master Nov 20, 2020
@Dean-Coakley Dean-Coakley deleted the refactor-sa-imagePullSecret branch November 20, 2020 17:13
@Dean-Coakley Dean-Coakley changed the title Change imagePullSecrets of helm chart to type string Replace deprecated imagePullSecrets helm setting Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants