Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Upstream Servers with pod_name label #1107

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Extend Upstream Servers with pod_name label #1107

merged 2 commits into from
Aug 28, 2020

Conversation

LorcanMcVeigh
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh commented Aug 24, 2020 •
edited
Loading

Proposed changes

This PR adds the pod_name label to upstream server metrics

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Aug 24, 2020
@LorcanMcVeigh LorcanMcVeigh force-pushed the pod-labels branch 2 times, most recently from 72ae867 to ec49efd Compare August 27, 2020 11:58
pleshakov
pleshakov approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LorcanMcVeigh LorcanMcVeigh merged commit 57d7647 into master Aug 28, 2020
@LorcanMcVeigh LorcanMcVeigh deleted the pod-labels branch August 28, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@lucacome lucacome Awaiting requested review from lucacome

Assignees

@LorcanMcVeigh LorcanMcVeigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LorcanMcVeigh @pleshakov @Dean-Coakley