Fix configuration lifetime and expose more config scopes #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main/server/location configuration objects belong to the cycle and will exist until the worker process is exiting. `'static` should help the compiler understand that we're returning a global object instead of borrowing from the `Request`.
bavshin-f5
force-pushed
the
conf-lifetime
branch
from
53d0e20 to
40a4dff
Compare
Use as_ref() for pointer-to-reference casts.
bavshin-f5
force-pushed
the
conf-lifetime
branch
2 times, most recently
from
3329286 to
8984de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
get_module_loc_confresult lifetime that made the Rust compiler think we're borrowing from theRequest.Expose
srv_confandmain_conf.