Skip to content

Fix for #41 and #50 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanitskiy merged 2 commits into from
Oct 26, 2023
Merged

Fix for #41 and #50 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d256f
fix(#41): zlib version update
mtb0x1 Oct 25, 2023
797bf24
fix(#50): user_agent method returns 'Option<&NgxStr>' and not '&NgxStr'
mtb0x1 Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ In short, this SDK allows writing NGINX modules using the Rust language.

NGINX modules can be built against a particular version of NGINX. The following environment variables can be used to specify a particular version of NGINX or an NGINX dependency:

* `ZLIB_VERSION` (default 1.2.13) -
* `ZLIB_VERSION` (default 1.3) -
* `PCRE2_VERSION` (default 10.42)
* `OPENSSL_VERSION` (default 3.0.7)
* `NGX_VERSION` (default 1.23.3) - NGINX OSS version
Expand Down
2 changes: 1 addition & 1 deletion examples/curl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ http_request_handler!(curl_access_handler, |request: &mut http::Request| {

match co.enable {
true => {
if request.user_agent().as_bytes().starts_with(b"curl") {
if request.user_agent().is_some_and(|ua| ua.as_bytes().starts_with(b"curl")) {
http::HTTPStatus::FORBIDDEN.into()
} else {
core::Status::NGX_DECLINED
Expand Down
2 changes: 1 addition & 1 deletion nginx-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use tar::Archive;
use which::which;

/// The default version of zlib to use if the `ZLIB_VERSION` environment variable is not present
const ZLIB_DEFAULT_VERSION: &str = "1.2.13";
const ZLIB_DEFAULT_VERSION: &str = "1.3";
const ZLIB_GPG_SERVER_AND_KEY_ID: (&str, &str) = ("keyserver.ubuntu.com", "783FCD8E58BCAFBA");
const ZLIB_DOWNLOAD_URL_PREFIX: &str = "https://www.zlib.net";
/// The default version of pcre2 to use if the `PCRE2_VERSION` environment variable is not present
Expand Down