Skip to content

Add uri to log when 'error getting stats' occured for nginx #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add uri to log when 'error getting stats' occured for nginx #1192

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39c17f6
Add uri to log when 'error getting stats' occured
AlexKorsakov Nov 4, 2025
5098840
Fix naming of GetAPIEndpoint
AlexKorsakov Nov 10, 2025
1480daf
Merge branch 'main' into main
AlexKorsakov Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client/nginx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,7 @@
}
return &s, nil
}

func (client *NginxClient) GetApiEndpoint() string {

Check failure on line 97 in client/nginx.go

View workflow job for this annotation

GitHub Actions / Go Lint 

var-naming: method GetApiEndpoint should be GetAPIEndpoint (revive)
return client.apiEndpoint
}
2 changes: 1 addition & 1 deletion collector/nginx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func (c *NginxCollector) Collect(ch chan<- prometheus.Metric) {
if err != nil {
c.upMetric.Set(nginxDown)
ch <- c.upMetric
c.logger.Error("error getting stats", "error", err.Error())
c.logger.Error("error getting stats", "uri", c.nginxClient.GetApiEndpoint(), "error", err)
return
}

Expand Down
Loading