Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 7, 2025

Proposed changes

  • Don't run Trivy scans on dry run
  • Avoid submitting preflight results for certification on dry run

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copilot AI review requested due to automatic review settings October 7, 2025 16:10
@pdabelf5 pdabelf5 requested a review from a team as a code owner October 7, 2025 16:10
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the release workflow to properly handle dry run mode by skipping security scans and certification submissions that shouldn't occur during testing.

  • Skip Trivy security scans entirely during dry run mode
  • Conditionally add the --submit flag to preflight checks only when not in dry run mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexFenlon AlexFenlon merged commit d9f0e03 into main Oct 8, 2025
7 checks passed
@AlexFenlon AlexFenlon deleted the chore/release-dry-run branch October 8, 2025 14:36
@pdabelf5 pdabelf5 restored the chore/release-dry-run branch October 10, 2025 09:04
@pdabelf5 pdabelf5 deleted the chore/release-dry-run branch October 10, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants