Skip to content

Updating references for public name #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2022
Merged

Updating references for public name #92

merged 1 commit into from
Apr 1, 2022

Conversation

f5yacobucci
Copy link
Contributor

Proposed changes

Make sure our references are consistent and will align with the new
repository name.

NGINX Kubernetes Gateway
and nginxinc/nginx-kubernetes-gateway

This will be a disruptive change as we update the repository name and references.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@f5yacobucci
Updating references for public name
0c2de48 
Make sure our references are consistent and will align with the new
repository name.

NGINX Kubernetes Gateway
and nginxinc/nginx-kubernetes-gateway
@pleshakov
Copy link
Contributor

pleshakov commented Apr 1, 2022 •
edited
Loading

Missed it :( https://github.com/nginxinc/nginx-gateway-kubernetes/blob/0c2de48eacb2f2d13b8934bc0c85eb52626e16db/deploy/manifests/nginx-gateway.yaml#L88 needs to be updated

@f5yacobucci f5yacobucci merged commit f3424e1 into nginx:main Apr 1, 2022
@kate-osborn kate-osborn mentioned this pull request Apr 1, 2022
Merged
6 tasks
@pammecrandall pammecrandall added the enhancement New feature or request label Aug 9, 2022
@lucacome lucacome added chore Pull requests for routine tasks and removed enhancement New feature or request labels Aug 19, 2022
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Updating references for public name (nginx#92)
b294373 
Make sure our references are consistent and will align with the new
repository name.

NGINX Kubernetes Gateway
and nginxinc/nginx-kubernetes-gateway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@f5yacobucci @pleshakov @pammecrandall @lucacome