Set GatewayClass status for ignored GatewayClasses #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
kate-osborn
suggested changes
Jun 29, 2023
kate-osborn
approved these changes
Jun 29, 2023
pleshakov
reviewed
Jun 29, 2023
Problem: It is expected that any GatewayClass that references our controller should have its status set properly, even if not used by our controller. Solution: Both the provisioner and controller will now add Accepted status False and ObservedGeneration to any GatewayClass that references our controller but is not configured to be used by our controller.
sjberman
force-pushed
the
bug/gateway-class-status
branch
from
a6d942a to
9c677a9
Compare
pleshakov
reviewed
Jun 30, 2023
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
@pleshakov let me know what you think of the change I pushed to handle this. Basically we delete the GC if the controller name doesn't equal our name. I know you're messing around with the code I altered, so not sure if there's a better solution for it.
sjberman
force-pushed
the
bug/gateway-class-status
branch
from
3bf7370 to
e8d9463
Compare
pleshakov
approved these changes
Jun 30, 2023
pleshakov
approved these changes
Jun 30, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: It is expected that any GatewayClass that references our controller should have its status set properly, even if not used by our controller. Solution: Both the provisioner and controller will now add Accepted status False and ObservedGeneration to any GatewayClass that references our controller but is not configured to be used by our controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: It is expected that any GatewayClass that references our controller should have its status set properly, even if not used by our controller.
Solution: Both the provisioner and controller will now add Accepted status False and ObservedGeneration to any GatewayClass that references our controller but is not configured to be used by our controller.
Testing: Conformance test now passes. Controller will also properly set statuses when not using provisioner.
Closes #775