Skip to content

Add summary of dependency review as comment in the PR #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2023
Merged

Add summary of dependency review as comment in the PR #753

merged 2 commits into from
Jun 15, 2023

Conversation

@lucacome
Copy link
Contributor

@lucacome lucacome commented Jun 13, 2023 •
edited
Loading

Proposed changes

Adds additional config option to add the summary of the dependency changes as a comment in the PR.
The additional permission of 'pull-requests: write' is required to post the comment.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome
Add summary of dependency review as comment in the PR
868daf3 
Adds additional config option to add the summary of the dependency
changes as a comment in the PR.
The additional permission of 'pull-requests: write' is required to post
the comment.
@lucacome lucacome requested a review from a team as a code owner June 13, 2023 23:35
@lucacome lucacome self-assigned this Jun 13, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 13, 2023
@lucacome lucacome merged commit 72263ef into nginx:main Jun 15, 2023
@lucacome lucacome deleted the chore/dependency-review-comment branch July 18, 2023 21:44
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Add summary of dependency review as comment in the PR (nginx#753)
9f4d68e 
Adds additional config option to add the summary of the dependency
changes as a comment in the PR.
The additional permission of 'pull-requests: write' is required to post
the comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjberman sjberman sjberman approved these changes

+1 more reviewer

@kate-osborn kate-osborn kate-osborn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucacome lucacome

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucacome @sjberman @kate-osborn