Skip to content

Conversation

@kate-osborn
Copy link
Contributor

In #633 I placed the Gateway conditions under the listener conditions. This PR moves the Gateway conditions under gateway.status.conditions and adds all the listener conditions to gateway.status.listeners.conditions

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner May 23, 2023 22:00
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 23, 2023
@kate-osborn kate-osborn force-pushed the docs/fix-gateway-conditions branch from bc4d1cf to d3a8d9e Compare May 24, 2023 15:25
@kate-osborn kate-osborn merged commit f4b00ef into nginx:main May 24, 2023
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants