Update statuses of HTTPRoutes #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new component - status.Updater - which updates statuses of HTTPRoutes. In the future, it will update statuses of the other supported resources. The added component has a few limitations (described in the comments) that are required to be addressed before the Gateway is considered to be ready for production use.
pleshakov
force-pushed
the
add-status-updater
branch
from
96fb095 to
e15b59f
Compare
f5yacobucci
reviewed
Feb 18, 2022
f5yacobucci
reviewed
Feb 22, 2022
f5yacobucci
reviewed
Feb 22, 2022
f5yacobucci
reviewed
Feb 22, 2022
f5yacobucci
reviewed
Feb 22, 2022
f5yacobucci
reviewed
Feb 22, 2022
f5yacobucci
reviewed
Feb 22, 2022
|
LGTM. Agreed to go over comments in more detail during 2/23 sync up. |
pleshakov
commented
Feb 23, 2022
f5yacobucci
approved these changes
Mar 10, 2022
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
This commit adds a new component - status.Updater - which updates statuses of HTTPRoutes. In the future, it will update statuses of the other supported resources. The added component has a few limitations (described in the comments) that are required to be addressed before the Gateway is considered to be ready for production use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new component - status.Updater - which updates
statuses of HTTPRoutes. In the future, it will update statuses of the
other supported resources.
The added component has a few limitations (described in the comments)
that are required to be addressed before the Gateway is considered to be
ready for production use.
Implements #59