Skip to content

Conversation

@shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Dec 1, 2025

Proposed changes

Corrects a typo in the header of the AuthenticationFilter proposal

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@shaun-nx shaun-nx requested review from a team as code owners December 1, 2025 16:24
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (565de36) to head (30a96a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4364      +/-   ##
==========================================
+ Coverage   86.12%   86.13%   +0.01%     
==========================================
  Files         132      132              
  Lines       14359    14359              
  Branches       35       35              
==========================================
+ Hits        12366    12368       +2     
+ Misses       1788     1787       -1     
+ Partials      205      204       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) December 2, 2025 16:03
@ADubhlaoich ADubhlaoich merged commit eb04371 into main Dec 4, 2025
59 of 60 checks passed
@ADubhlaoich ADubhlaoich deleted the chore/proposal-typo branch December 4, 2025 17:07
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants