-
Notifications
You must be signed in to change notification settings - Fork 140
Add fix for inference pool status #4088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for inference pool status #4088
Conversation
I re-applied the base yamls from the conformance test and each time this was the status: Which is correct since these have two different ParentRef Gateways. My fix shouldn't have solved any issues. |
no like reply any of the inference pools yaml and see if the status gets repeated instead of overwritten |
Are you asking specifically for me to test on a failing/unaccepted status? Because what I described above was me re-applying the inference-pool yaml, and the status does not get repeated on the default accepted and resolved statuses. |
Okay just needed to confirm. Thank you Ben |
When setting inference pool statuses, it loops through all the inference pools and checks if there are any nginx gateways that have parentRefs in the statuses. If there are AND the infernece pool is not referenced (not connected to the graph), it will remove that parentRef.
When setting inference pool statuses, it loops through all the inference pools and checks if there are any nginx gateways that have parentRefs in the statuses. If there are AND the infernece pool is not referenced (not connected to the graph), it will remove that parentRef.
When setting inference pool statuses, it loops through all the inference pools and checks if there are any nginx gateways that have parentRefs in the statuses. If there are AND the infernece pool is not referenced (not connected to the graph), it will remove that parentRef.