Skip to content

Fix failing unit tests #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

Fix failing unit tests #3901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions internal/controller/state/graph/backend_refs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,9 +1664,6 @@ func TestFindBackendTLSPolicyForService(t *testing.T) {
},
}
}
oldestBtp := getBtp("oldest", oldCreationTimestamp)
newestBtp := getBtp("newest", newCreationTimestamp)
alphaFirstBtp := getBtp("alphabeticallyfirst", oldCreationTimestamp)

ref := gatewayv1.HTTPBackendRef{
BackendRef: gatewayv1.BackendRef{
Expand All @@ -1678,26 +1675,39 @@ func TestFindBackendTLSPolicyForService(t *testing.T) {
},
}

getBTPMap := func(nameAndTimestamp map[string]metav1.Time) map[types.NamespacedName]*BackendTLSPolicy {
m := make(map[types.NamespacedName]*BackendTLSPolicy, len(nameAndTimestamp))
for n, ts := range nameAndTimestamp {
btp := getBtp(n, ts)
m[client.ObjectKeyFromObject(btp.Source)] = btp
}
return m
}

tests := []struct {
name string
backendTLSPolicies map[types.NamespacedName]*BackendTLSPolicy
expectedBtpName string
}{
{
name: "oldest wins",
backendTLSPolicies: map[types.NamespacedName]*BackendTLSPolicy{
client.ObjectKeyFromObject(newestBtp.Source): newestBtp,
client.ObjectKeyFromObject(oldestBtp.Source): oldestBtp,
},
backendTLSPolicies: getBTPMap(
map[string]metav1.Time{
"newest": newCreationTimestamp,
"oldest": oldCreationTimestamp,
},
),
expectedBtpName: "oldest",
},
{
name: "alphabetically first wins",
backendTLSPolicies: map[types.NamespacedName]*BackendTLSPolicy{
client.ObjectKeyFromObject(oldestBtp.Source): oldestBtp,
client.ObjectKeyFromObject(alphaFirstBtp.Source): alphaFirstBtp,
client.ObjectKeyFromObject(newestBtp.Source): newestBtp,
},
backendTLSPolicies: getBTPMap(
map[string]metav1.Time{
"alphabeticallyfirst": oldCreationTimestamp,
"newest": newCreationTimestamp,
"oldest": oldCreationTimestamp,
},
),
expectedBtpName: "alphabeticallyfirst",
},
}
Expand Down
Loading