-
Notifications
You must be signed in to change notification settings - Fork 138
Prevent policy includes
duplication in advanced routing configuration
#3799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3799 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 128 128
Lines 16404 16404
Branches 62 62
=======================================
Hits 14272 14272
Misses 1957 1957
Partials 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
does the bug only occur when we attach the CSP to HTTPRoute? have we verified this for the gateway? |
That's a great question. I'll check if that's the case. |
@salonichf5 @sjberman the test is working now. This here is an example of the Actual and Expected config results when running the test against the code with the bug Actual:
Expected:
Difference
What this means
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@salonichf5 just on this. This bug doesn't affect the Gateway resource as the bug is related to how Policies are added to hostPathRules specifically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the clarification
Proposed changes
This change ensures that, when deploying a
HTTPRoute
with an advanced routing configuration, and aClientSettingsPolicy
is targeting this kind of route, we do not duplicate client settings in NGINXFixes (#3763)
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.