-
Couldn't load subscription status.
- Fork 141
Fix policy attachment when ancestors slice is full #3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix policy attachment when ancestors slice is full #3698
Conversation
b5891a0 to
3041aa9
Compare
e02c8bb to
624fd46
Compare
5a0abd0 to
ad62fba
Compare
34594c9 to
2b2a2b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I tested it locally and everything seems to be working as expected.
Excellent work @sarthyparty 🥳!🔥 🔥 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
cee735f to
0ae3ca8
Compare
Proposed changes
Problem: Multiple bugs when ancestor slice was full:
Solution: Added conditions to ancestor and logs to controller. I fixed BackendTLSPolicy to add attachments until ancestors became full and fixed NGF policies as well
Testing: Currently unit tests and manual tested
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1987
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.