Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to new repo #2983

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Update references to new repo #2983

merged 3 commits into from
Jan 7, 2025

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jan 6, 2025

Proposed changes

Updates from nginxinc to nginx

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NGINX Gateway Fabric moved from nginxinc to nginx

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file chore Pull requests for routine tasks helm-chart Relates to helm chart labels Jan 6, 2025
@lucacome lucacome requested a review from a team January 6, 2025 23:25
sjberman
sjberman reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this PR is not yet updating the image paths to push to the new path, yes? So still pushing to the old one.

@lucacome
Copy link
Member Author

lucacome commented Jan 7, 2025

@sjberman I was thinking about doing that in a different PR, but now I realize that the pipeline will probably fail to push edge. I think I should add to this one, thoughts?

@sjberman
Copy link
Collaborator

sjberman commented Jan 7, 2025

Yeah we probably need to update it now.

We also will need to fix the NFR upgrade tests before code freeze.

@lucacome lucacome requested a review from sjberman January 7, 2025 00:34
@lucacome lucacome merged commit 819b866 into nginx:main Jan 7, 2025
47 checks passed
@lucacome lucacome deleted the chore/new-repo branch January 7, 2025 00:49
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Update references to new repo (nginx#2983)
d1497a3 
Updates from nginxinc to nginx
lucacome added a commit that referenced this pull request Jan 16, 2025
@lucacome
Update references to new repo (#2983)
092ea7d 
Updates from nginxinc to nginx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @sjberman @kate-osborn