-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usage reporting in automated tests #2971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening as draft to test in pipeline |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
=======================================
Coverage 89.93% 89.93%
=======================================
Files 111 111
Lines 11423 11423
Branches 50 50
=======================================
Hits 10273 10273
Misses 1089 1089
Partials 61 61 ☔ View full report in Codecov by Sentry. |
kate-osborn
force-pushed
the
tests/improve-usage-reporting
branch
from
January 3, 2025 19:08
61d087c
to
9a47b6d
Compare
I'm still waiting on the NFR workflow to complete, but this can be reviewed in the meantime. |
sindhushiv
reviewed
Jan 3, 2025
sjberman
approved these changes
Jan 3, 2025
sindhushiv
approved these changes
Jan 3, 2025
kate-osborn
force-pushed
the
tests/improve-usage-reporting
branch
from
January 3, 2025 22:57
e63d65d
to
a8702ce
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: Pipelines are failing intermittently due to r33 reporting errors. Solutions: - In the graceful recovery and reconfig tests, do not fail if there are errors in the NGINX logs. Instead, log the errors and continue. In the reconfig tests, all NGINX error logs are captured in the results file. Since the graceful recovery tests are part of the functional tests that run on every push to a PR and merge to main, it is not desirable to write the error logs to a file. Instead, if an unexpected error is seen in the NGINX logs, the test is skipped and the error is logged in the test output. Since we are sending traffic through NGINX during the graceful recovery tests, we will still catch any unrecoverable NGINX errors. - Reporting for conformance tests is disabled.
lucacome
pushed a commit
that referenced
this pull request
Jan 16, 2025
Problem: Pipelines are failing intermittently due to r33 reporting errors. Solutions: - In the graceful recovery and reconfig tests, do not fail if there are errors in the NGINX logs. Instead, log the errors and continue. In the reconfig tests, all NGINX error logs are captured in the results file. Since the graceful recovery tests are part of the functional tests that run on every push to a PR and merge to main, it is not desirable to write the error logs to a file. Instead, if an unexpected error is seen in the NGINX logs, the test is skipped and the error is logged in the test output. Since we are sending traffic through NGINX during the graceful recovery tests, we will still catch any unrecoverable NGINX errors. - Reporting for conformance tests is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Pipelines are failing intermittently due to r33 reporting errors.
Solutions:
Testing: Ran graceful recovery and reconfig tests locally and verified new behavior.
Example of NGINX error logs in reconfig results:
Example of NGINX error logs outputted by graceful recovery tests (this error was forced by commenting out an expected error message):
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.