Fix duplicate ancestors on UpstreamSettingsPolicy status #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sjberman
approved these changes
Dec 19, 2024
salonichf5
approved these changes
Dec 19, 2024
kate-osborn
merged commit 7617e26
into
nginx:feature/upstream-settings-policy
37 checks passed
kate-osborn
added a commit
to kate-osborn/nginx-gateway-fabric
that referenced
this pull request
Dec 20, 2024
Problem: When an UpstreamSettingsPolicy targeted multiple Services, NGF would write duplicate ancestors to its status. Solution: Only add unique ancestors to policy ancestors list.
kate-osborn
added a commit
that referenced
this pull request
Dec 20, 2024
Problem: When an UpstreamSettingsPolicy targeted multiple Services, NGF would write duplicate ancestors to its status. Solution: Only add unique ancestors to policy ancestors list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: When an UpstreamSettingsPolicy targeted multiple Services, NGF would write duplicate ancestors to its status.
Solution: Only add unique ancestors to policy ancestors list.
Testing: Added unit tests and manually verified that only one ancestor is written to the status.
Closes #2935
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.