Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the email support section from the NGF README file #2823

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

sindhushiv
Copy link
Collaborator

@sindhushiv sindhushiv commented Nov 26, 2024

Proposed changes

Problem: Email support for users was provided through [email protected] in NGF.

Solution: Removed email support from NGF and updated the README file accordingly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated the necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@sindhushiv sindhushiv requested a review from a team as a code owner November 26, 2024 22:00
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@sindhushiv sindhushiv self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (0d83a7f) to head (be9abe5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2823   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sindhushiv
Copy link
Collaborator Author

I have hereby read the F5 CLA and agree to its terms

@sindhushiv sindhushiv merged commit 5b38d8c into nginx:main Nov 26, 2024
40 checks passed
salonichf5 pushed a commit to salonichf5/nginx-gateway-fabric that referenced this pull request Dec 5, 2024
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants