-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gateway api version to 1.2.0 #2694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
+ Coverage 88.97% 88.99% +0.02%
==========================================
Files 110 110
Lines 8615 8632 +17
Branches 50 50
==========================================
+ Hits 7665 7682 +17
Misses 892 892
Partials 58 58 ☔ View full report in Codecov by Sentry. |
sjberman
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of places missed:
- README tech specs chart
- SupportedVersion string in the code
- controllerNameRegex comment link in validation.go
a3f21fd
to
07f8bca
Compare
07f8bca
to
f343ee2
Compare
sjberman
approved these changes
Oct 16, 2024
bjee19
approved these changes
Oct 16, 2024
f343ee2
to
c6a8b9d
Compare
c6a8b9d
to
0aeac0c
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Upgrade the gateway api version to v1.2.0 Problem: Need to upgrade the gateway-api version from 1.1.0 -> 1.2.0 Solution: Update gateway-api version to 1.2.0 and made other necessary updates to be integrated with NGF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Need to upgrade the gateway-api version from 1.1.0 -> 1.2.0
Solution: Update gateway-api version to 1.2.0 and made other necessary updates to be integrated with NGF.
Testing: Ran unit-tests and functional tests a couple of times. (passed)
Tested NGF build with cafe example to see everything works as is. Verified pod and NGF logs don't have any errors.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2656
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.