Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gateway api version to 1.2.0 #2694

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Need to upgrade the gateway-api version from 1.1.0 -> 1.2.0

Solution: Update gateway-api version to 1.2.0 and made other necessary updates to be integrated with NGF.

Testing: Ran unit-tests and functional tests a couple of times. (passed)
Tested NGF build with cafe example to see everything works as is. Verified pod and NGF logs don't have any errors.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #2656

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested a review from a team as a code owner October 16, 2024 19:22
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.99%. Comparing base (f2da836) to head (0aeac0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
+ Coverage   88.97%   88.99%   +0.02%     
==========================================
  Files         110      110              
  Lines        8615     8632      +17     
  Branches       50       50              
==========================================
+ Hits         7665     7682      +17     
  Misses        892      892              
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of places missed:

  • README tech specs chart
  • SupportedVersion string in the code
  • controllerNameRegex comment link in validation.go

@salonichf5 salonichf5 force-pushed the chore/upgrade-gateway-api-1.2 branch from a3f21fd to 07f8bca Compare October 16, 2024 20:58
@salonichf5 salonichf5 changed the title update gateway api version to 1.2.0 Update gateway api version to 1.2.0 Oct 16, 2024
@salonichf5 salonichf5 force-pushed the chore/upgrade-gateway-api-1.2 branch from 07f8bca to f343ee2 Compare October 16, 2024 21:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2024
@salonichf5 salonichf5 requested a review from sjberman October 16, 2024 21:08
@salonichf5 salonichf5 force-pushed the chore/upgrade-gateway-api-1.2 branch from f343ee2 to c6a8b9d Compare October 16, 2024 22:32
@salonichf5 salonichf5 enabled auto-merge (squash) October 16, 2024 22:54
@salonichf5 salonichf5 force-pushed the chore/upgrade-gateway-api-1.2 branch from c6a8b9d to 0aeac0c Compare October 16, 2024 22:55
@salonichf5 salonichf5 merged commit 9fb1d37 into main Oct 16, 2024
38 checks passed
@salonichf5 salonichf5 deleted the chore/upgrade-gateway-api-1.2 branch October 16, 2024 23:07
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Upgrade the gateway api version to v1.2.0

Problem: Need to upgrade the gateway-api version from 1.1.0 -> 1.2.0

Solution: Update gateway-api version to 1.2.0 and made other necessary updates to be integrated with NGF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update to Gateway API 1.2
3 participants