Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker updater workflow #2679

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

lucacome
Copy link
Member

Proposed changes

Fixing a few issues in the workflow, mainly the build step that had a wrong if (all the outputs are strings).
Also adding an option to force the update.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner October 11, 2024 17:48
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (fac76d7) to head (dc46bd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2679   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         110      110           
  Lines        8556     8556           
  Branches       50       50           
=======================================
  Hits         7606     7606           
  Misses        892      892           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit 7644959 into nginx:main Oct 11, 2024
42 checks passed
@lucacome lucacome deleted the chore/update-workflow branch October 11, 2024 19:59
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Fixed a few issues in the workflow, mainly the build step that had a wrong if (all the outputs are strings).
Also added an option to force the update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants