Increase lint timeout to 3m #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint make command consistently times out. This commit increases the timeout from default of 1 minute to 3 minutes.
|
we could set it in the config like here https://github.com/nginxinc/kubernetes-ingress/blob/main/.golangci.yml#L66 |
Good suggestion, moved it to the config file. |
lucacome
approved these changes
Sep 19, 2022
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Increase lint timeout to 3m The lint make command consistently times out. This commit increases the timeout from default of 1 minute to 3 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint make command consistently times out. This commit increases the timeout from default of 1 minute to 3 minutes.