Skip to content

Use edge tag in examples and makefile #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Use edge tag in examples and makefile #192

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05fc55a
Use edge tag in examples and makefile
Aug 17, 2022
edab7ae
Version not target
Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ PREFIX ?= nginx-kubernetes-gateway
GIT_COMMIT = $(shell git rev-parse HEAD)
DATE = $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")

TARGET ?= local
TARGET ?= edge

KIND_KUBE_CONFIG_FOLDER = $${HOME}/.kube/kind
OUT_DIR=$(shell pwd)/build/.out
Expand Down
2 changes: 1 addition & 1 deletion deploy/manifests/nginx-gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ spec:
- name: nginx-config
mountPath: /etc/nginx
containers:
- image: nginx-kubernetes-gateway:0.0.1
- image: nginx-kubernetes-gateway:edge
imagePullPolicy: IfNotPresent
name: nginx-gateway
volumeMounts:
Expand Down
6 changes: 3 additions & 3 deletions docs/building-the-image.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ Before you can build the NGINX Kubernetes Gateway, make sure you have the follow
make PREFIX=myregistry.example.com/nginx-kubernetes-gateway container
```

Set the `PREFIX` variable to the name of the registry you'd like to push the image to. By default, the image will be named `nginx-kubernetes-gateway:0.0.1`.
Set the `PREFIX` variable to the name of the registry you'd like to push the image to. By default, the image will be named `nginx-kubernetes-gateway:edge`.

1. Push the image to your container registry:

```
docker push myregistry.example.com/nginx-kubernetes-gateway:0.0.1
docker push myregistry.example.com/nginx-kubernetes-gateway:edge
```

Make sure to substitute `myregistry.example.com/nginx-kubernetes-gateway` with your registry.
Make sure to substitute `myregistry.example.com/nginx-kubernetes-gateway` with your registry.
4 changes: 2 additions & 2 deletions docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ You can deploy NGINX Kubernetes Gateway on an existing Kubernetes 1.16+ cluster.
1. Load the NGINX Kubernetes Gateway image onto your kind cluster:

```
kind load docker-image nginx-kubernetes-gateway:0.0.1
kind load docker-image nginx-kubernetes-gateway:edge
```

Make sure to substitute the image name with the name of the image you built.
Expand Down Expand Up @@ -107,4 +107,4 @@ Create a service with type `LoadBalancer` using the appropriate manifest for you

```
nslookup <dns-name>
```
```