Add missing labels and remove unnecessary build-args #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata-action produces Docker labels automatically, with this change we add the output of that step to the build. GoReleaser already has the Version, Date and Commit hash info available, so we don't need to pass them as parameters to the build.
kate-osborn
approved these changes
Aug 17, 2022
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
The metadata-action produces Docker labels automatically, with this change we add the output of that step to the build. GoReleaser already has the Version, Date and Commit hash info available, so we don't need to pass them as parameters to the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata-action produces Docker labels automatically, with this change
we add the output of that step to the build.
GoReleaser already has the Version, Date and Commit hash info available,
so we don't need to pass them as parameters to the build.