Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate webhook-related assumptions #515

Closed
Tracked by #308
pleshakov opened this issue Mar 30, 2023 · 0 comments · Fixed by #565
Closed
Tracked by #308

Validate webhook-related assumptions #515

pleshakov opened this issue Mar 30, 2023 · 0 comments · Fixed by #565
Assignees
@pleshakov
Labels
area/gateway/core Relates to all Core features of Gateway area/gatewayclass/core Relates to all Core features of GatewayClass area/httproute/core Relates to all Core features of HTTPRoute refined Requirements are refined and the issue is ready to be implemented. tech-debt Short-term pain, long-term benefit
Milestone
v0.3.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Mar 30, 2023 •
edited
Loading

Ensure that the code in the state package confirm any assumptions about how the webhook validates the Gateway API resources via unit tests.

(branched out from #416 to reduce the scope of that issue)
@pleshakov pleshakov added proposal tech-debt Short-term pain, long-term benefit and removed proposal labels Mar 30, 2023
@pleshakov pleshakov added this to the v0.3.0 milestone Mar 30, 2023
@pleshakov pleshakov self-assigned this Mar 30, 2023
@pleshakov pleshakov added area/httproute/core Relates to all Core features of HTTPRoute area/gateway/core Relates to all Core features of Gateway area/gatewayclass/core Relates to all Core features of GatewayClass refined Requirements are refined and the issue is ready to be implemented. labels Mar 30, 2023
@pleshakov pleshakov mentioned this issue Mar 30, 2023
Closed
9 tasks
@pleshakov pleshakov mentioned this issue Apr 6, 2023
Merged
pleshakov added a commit that referenced this issue Apr 6, 2023
@pleshakov
Panic for broken webhook validation assumption
ba2f63c 
- Add panics for cases when an assumption about how webhook validation
(run by NKG) validates a Gateway API resource is broken.
- Add unit tests for those cases to ensure that invalid resources
don't reach the code that makes those assumptions. Note: panics are not
unit tested as we considered it'd be redundant.

Fixes #515
pleshakov added a commit that referenced this issue Apr 7, 2023
@pleshakov
Panic for broken webhook validation assumption (#565)
6b3a7c2 
- Add panics for cases when an assumption about how webhook validation
(run by NKG) validates a Gateway API resource is broken.
- Add unit tests for those cases to ensure that invalid resources
don't reach the code that makes those assumptions. Note: panics are not
unit tested as we considered it'd be redundant.

Fixes #515
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Panic for broken webhook validation assumption (nginx#565)
7871812 
- Add panics for cases when an assumption about how webhook validation
(run by NKG) validates a Gateway API resource is broken.
- Add unit tests for those cases to ensure that invalid resources
don't reach the code that makes those assumptions. Note: panics are not
unit tested as we considered it'd be redundant.

Fixes nginx#515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
area/gateway/core Relates to all Core features of Gateway area/gatewayclass/core Relates to all Core features of GatewayClass area/httproute/core Relates to all Core features of HTTPRoute refined Requirements are refined and the issue is ready to be implemented. tech-debt Short-term pain, long-term benefit
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Panic for broken webhook validation assumption nginx/nginx-gateway-fabric
1 participant
@pleshakov