Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NKG-specific Gateway validation consistent with HTTPRoute #473

Closed
Tracked by #308
pleshakov opened this issue Mar 16, 2023 · 0 comments · Fixed by #503
Closed
Tracked by #308

Make NKG-specific Gateway validation consistent with HTTPRoute #473

pleshakov opened this issue Mar 16, 2023 · 0 comments · Fixed by #503
Labels
area/gatewayclass/core Relates to all Core features of GatewayClass enhancement New feature or request
Milestone
v0.3.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Mar 16, 2023 •
edited
Loading

This PR #455 brought NKG-specific validation for HTTPRoutes. The implementation uses https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field to generate validation errors.

Make Gateway-related errors consistent with HTTPRoute-related errors (start using that package above)

Aha! Link: https://nginx.aha.io/features/NKG-57
@pleshakov pleshakov added the enhancement New feature or request label Mar 16, 2023
@pleshakov pleshakov changed the title Make NGK-specific Gateway validation consistent with HTTPRoute Make NKG-specific Gateway validation consistent with HTTPRoute Mar 16, 2023
@pleshakov pleshakov mentioned this issue Mar 16, 2023
Closed
9 tasks
@kate-osborn kate-osborn added the area/gatewayclass/core Relates to all Core features of GatewayClass label Mar 21, 2023
@kate-osborn kate-osborn added this to the v0.3.0 milestone Mar 21, 2023
pleshakov added a commit that referenced this issue Mar 23, 2023
@pleshakov
Improve Gateway validation error messages
d472b24 
The PR #455
brought NKG-specific validation for HTTPRoutes. The implementation uses
https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field 
to generate validation errors.

This commit makes generated Gateway-related errors consistent with
HTTPRoute-related errors by starting using that package above.

Fixes #473
@pleshakov pleshakov mentioned this issue Mar 23, 2023
Merged
pleshakov added a commit that referenced this issue Mar 23, 2023
@pleshakov
Improve Gateway validation error messages (#503)
c473aba 
The PR #455
brought NKG-specific validation for HTTPRoutes. The implementation uses
https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field 
to generate validation errors.

This commit makes generated Gateway-related errors consistent with
HTTPRoute-related errors by starting using that package above.

Fixes #473
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Improve Gateway validation error messages (nginx#503)
1fc8942 
The PR nginx#455
brought NKG-specific validation for HTTPRoutes. The implementation uses
https://pkg.go.dev/k8s.io/apimachinery/pkg/util/validation/field 
to generate validation errors.

This commit makes generated Gateway-related errors consistent with
HTTPRoute-related errors by starting using that package above.

Fixes nginx#473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/gatewayclass/core Relates to all Core features of GatewayClass enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Improve Gateway validation error messages nginx/nginx-gateway-fabric
2 participants
@pleshakov @kate-osborn