Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant warnings #467

Closed
Tracked by #308
pleshakov opened this issue Mar 14, 2023 · 0 comments · Fixed by #502
Closed
Tracked by #308

Remove redundant warnings #467

pleshakov opened this issue Mar 14, 2023 · 0 comments · Fixed by #502
Assignees
@pleshakov
Labels
area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request
Milestone
v0.3.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Mar 14, 2023 •
edited
Loading

The warnings reported by dataplane.BuildConfiguration() are nowredundant - they are reported as Conditions in the statuses of Gateway API resources, which includes warnings-related cases for:

  • invalid listener in an HTTPRoute
  • unresolved backend ref an HTTPRoute

Remove the code that generates and reports warnings.

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/99320a55aa253df4920d9e08f1b166afab500483/internal/state/change_processor.go#L174

Aha! Link: https://nginx.aha.io/features/NKG-55
@pleshakov pleshakov added proposal enhancement New feature or request and removed proposal labels Mar 14, 2023
@pleshakov pleshakov mentioned this issue Mar 16, 2023
Closed
9 tasks
@kate-osborn kate-osborn added the area/httproute/core Relates to all Core features of HTTPRoute label Mar 21, 2023
@kate-osborn kate-osborn modified the milestones: v1.0.0, v0.3.0 Mar 21, 2023
@pleshakov pleshakov changed the title Report Conditions rather than log Warnings after building configuration Remove redundant warnings Mar 23, 2023
pleshakov added a commit that referenced this issue Mar 23, 2023
@pleshakov
Remove redundant warnings
10499e0 
The warnings reported by dataplane.BuildConfiguration() are now
redundant - they are reported as Conditions in the statuses of
Gateway API resources, which includes warnings-related cases for:
* invalid listener in an HTTPRoute
* unresolved backend ref an HTTPRoute

This commit removes the code, which generates and reports warnings.

Additionally, the commit fixes a related test TestBuildConfiguration
case "invalid listener": if a listener is invalid, it cannot include
any Routes and AcceptedHostnames, so those fields are removed.

Fixes #467
@pleshakov pleshakov mentioned this issue Mar 23, 2023
Merged
pleshakov added a commit that referenced this issue Mar 23, 2023
@pleshakov
Remove redundant warnings (#502)
c9d912c 
The warnings reported by dataplane.BuildConfiguration() are now
redundant - they are reported as Conditions in the statuses of
Gateway API resources, which includes warnings-related cases for:
* invalid listener in an HTTPRoute
* unresolved backend ref an HTTPRoute

This commit removes the code, which generates and reports warnings.

Additionally, the commit fixes a related test TestBuildConfiguration
case "invalid listener": if a listener is invalid, it cannot include
any Routes and AcceptedHostnames, so those fields are removed.

Fixes #467
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Remove redundant warnings (nginx#502)
3d71b58 
The warnings reported by dataplane.BuildConfiguration() are now
redundant - they are reported as Conditions in the statuses of
Gateway API resources, which includes warnings-related cases for:
* invalid listener in an HTTPRoute
* unresolved backend ref an HTTPRoute

This commit removes the code, which generates and reports warnings.

Additionally, the commit fixes a related test TestBuildConfiguration
case "invalid listener": if a listener is invalid, it cannot include
any Routes and AcceptedHostnames, so those fields are removed.

Fixes nginx#467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Remove redundant warnings nginx/nginx-gateway-fabric
2 participants
@pleshakov @kate-osborn