Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NKG-specific field validation for HTTPRoute resource #412

Closed
Tracked by #363
pleshakov opened this issue Feb 6, 2023 · 0 comments · Fixed by #455
Closed
Tracked by #363

Implement NKG-specific field validation for HTTPRoute resource #412

pleshakov opened this issue Feb 6, 2023 · 0 comments · Fixed by #455
Assignees
@pleshakov
Labels
enhancement New feature or request

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Feb 6, 2023 •
edited by brianehlert
Loading

Parent issue -- #363

This issue implements requirements of #363 for HTTPRoute resource

Aha! Link: https://nginx.aha.io/features/NKG-44
@pleshakov pleshakov added the enhancement New feature or request label Feb 6, 2023
@pleshakov pleshakov mentioned this issue Feb 6, 2023
Closed
3 tasks
pleshakov added a commit that referenced this issue Mar 7, 2023
@pleshakov
Add NKG-specific field validation for HTTPRoutes
2f01d7a 
- Introduce HTTPFieldsValidator interface for validating fields of
HTTP-related Gateway API resources according to the data-plane specific
rules.
- Validate HTTPRoute resources when building the graph using data-plane
agnostic rules.
- Validate HTTPRoute resources when building the graph using
HTTPFieldsValidator according to the data-plane rules.
- Implement an HTTPFieldsValidator for NGINX-specific validation rules.

Fixes #412
@pleshakov pleshakov mentioned this issue Mar 7, 2023
Merged
@pleshakov pleshakov self-assigned this Mar 14, 2023
pleshakov added a commit that referenced this issue Mar 16, 2023
@pleshakov
Add NKG-specific field validation for HTTPRoutes (#455)
52fab05 
* Add NKG-specific field validation for HTTPRoutes

- Introduce HTTPFieldsValidator interface for validating fields of
HTTP-related Gateway API resources according to the data-plane specific
rules.
- Validate HTTPRoute resources when building the graph using data-plane
agnostic rules.
- Validate HTTPRoute resources when building the graph using
HTTPFieldsValidator according to the data-plane rules.
- Implement an HTTPFieldsValidator for NGINX-specific validation rules.

Fixes #412

* Apply suggestions on GitHub
Co-authored-by: Kate Osborn <[email protected]>
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Add NKG-specific field validation for HTTPRoutes (nginx#455)
752e45b 
* Add NKG-specific field validation for HTTPRoutes

- Introduce HTTPFieldsValidator interface for validating fields of
HTTP-related Gateway API resources according to the data-plane specific
rules.
- Validate HTTPRoute resources when building the graph using data-plane
agnostic rules.
- Validate HTTPRoute resources when building the graph using
HTTPFieldsValidator according to the data-plane rules.
- Implement an HTTPFieldsValidator for NGINX-specific validation rules.

Fixes nginx#412

* Apply suggestions on GitHub
Co-authored-by: Kate Osborn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement NKG-specific field validation for HTTPRoutes nginx/nginx-gateway-fabric
1 participant
@pleshakov